netdev - Re: [PATCH v3 4/4] packet: Add pre-defragmentation support for ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1309966077.2292.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Wed, 06 Jul 2011 17:27:57 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	mika.penttila@...nos.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 4/4] packet: Add pre-defragmentation support for ipv4

Le mercredi 06 juillet 2011 à 08:20 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wed, 06 Jul 2011 17:18:09 +0200
> 
> > [PATCH] packet: fix a leak in fanout_check_defrag()
> > 
> > Reported-by: Penttilä Mika <mika.penttila@...nos.com>
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Eric, see what I commited, it's much simpler than all
> of this code movement you added, ala skb_share_check()
> :-)

I tried to not lose the original packet and let application catch it ;)

We probably need to add some atomic_inc(&sk->sk_drops) to at least warn
the application.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html