netdev - Re: [RFC 43/72] a2065/ariadne: Move the a2065/ariadne drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1310221836.26989.11.camel@jtkirshe-mobl>
Date:	Sat, 09 Jul 2011 07:30:26 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC 43/72] a2065/ariadne: Move the a2065/ariadne drivers

On Tue, 2011-06-28 at 13:33 -0700, Geert Uytterhoeven wrote:
> On Sat, Jun 25, 2011 at 15:58, Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> > --- a/drivers/net/ethernet/Kconfig
> > +++ b/drivers/net/ethernet/Kconfig
> > @@ -12,8 +12,31 @@ menuconfig ETHERNET
> >  if ETHERNET
> >
> >  source "drivers/net/ethernet/3com/Kconfig"
> > +
> > +config A2065
> > +       tristate "A2065 support"
> > +       depends on ZORRO
> > +       select CRC32
> > +       ---help---
> > +         If you have a Commodore A2065 Ethernet adapter, say Y. Otherwise,
> > +         say N.
> > +
> > +         To compile this driver as a module, choose M here: the module
> > +         will be called a2065.
> > +
> >  source "drivers/net/ethernet/amd/Kconfig"
> >  source "drivers/net/ethernet/apple/Kconfig"
> > +
> > +config ARIADNE
> > +       tristate "Ariadne support"
> > +       depends on ZORRO
> > +       ---help---
> > +         If you have a Village Tronic Ariadne Ethernet adapter, say Y.
> > +         Otherwise, say N.
> > +
> > +         To compile this driver as a module, choose M here: the module
> > +         will be called ariadne.
> > +
> >  source "drivers/net/ethernet/arm/Kconfig"
> >  source "drivers/net/ethernet/atheros/Kconfig"
> 
> What's the rationale behind this "restructuring"?

In short to better organize drivers/net/.  There are a large number of
drivers in drivers/net/ so we are trying to organize the directory
structure to make it easier to maintain in the future.

> FWIW, both the A2065 and Ariadne drivers are for AMD LANCE variants
> (that is Am7990 and Am79C960)?

I saw that they were LANCE variants, yet did not use the "common" LANCE
code like the other LANCE drivers.  Based on suggestions from Arnd
Bergmann and Joe Perches, I am moving these into the AMD LANCE driver
directory.

> 
> And (in some other patch) 82596.c is an Intel driver, not a Motorola driver.

82596.c is not an Intel driver, it is an Intel part.  The driver was
written and support by someone other than Intel.  I am looking at how to
better organize the 82596.c, lasi_82596.c, lib82596.c, and sni_82596.c
which all use an Intel Ethernet chip but were written and supported by
someone other than Intel.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)