netdev - Re: [PATCH 15/21] net: tulip/de2104x: use common rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110709223144.GA5744@electric-eye.fr.zoreil.com>
Date:	Sun, 10 Jul 2011 00:31:44 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org, Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH 15/21] net: tulip/de2104x: use common rx_copybreak handling [strict refill!]

Michał Mirosław <mirq-linux@...e.qmqm.pl> :
[...]
> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
> index ce90efc..80a34b6 100644
> --- a/drivers/net/tulip/de2104x.c
> +++ b/drivers/net/tulip/de2104x.c
> @@ -432,42 +431,22 @@ static void de_rx (struct de_private *de)
>  			goto rx_next;
>  		}
>  
> -		copying_skb = (len <= rx_copybreak);
> -
>  		netif_dbg(de, rx_status, de->dev,
>  			  "rx slot %d status 0x%x len %d copying? %d\n",
> -			  rx_tail, status, len, copying_skb);
> +			  rx_tail, status, len, len <= rx_copybreak);
>  
> -		buflen = copying_skb ? (len + RX_OFFSET) : de->rx_buf_sz;
> -		copy_skb = dev_alloc_skb (buflen);
> -		if (unlikely(!copy_skb)) {
> +		skb = dev_skb_finish_rx_dma_refill(&de->rx_skb[rx_tail].skb,
> +			len, rx_copybreak, 0, RX_OFFSET,
> +			&de->pdev->dev, &mapping, de->rx_buf_sz);
> +		de->rx_skb[rx_tail].mapping = mapping;
> +
> +		if (unlikely(!skb)) {

s/skb/de->rx_skb[rx_tail].skb/

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html