netdev - Re: [PATCH 02/21] net: 3c59x: use common rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110709232339.GA15588@rere.qmqm.pl>
Date:	Sun, 10 Jul 2011 01:23:39 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org,
	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
Subject: Re: [PATCH 02/21] net: 3c59x: use common rx_copybreak handling

On Sun, Jul 10, 2011 at 12:22:58AM +0200, Francois Romieu wrote:
> Michał Mirosław <mirq-linux@...e.qmqm.pl> :
> [...]
> > diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> > index 8cc2256..456726c 100644
> > --- a/drivers/net/3c59x.c
> > +++ b/drivers/net/3c59x.c
> [...]
> > +			skb = dev_skb_finish_rx_dma(&vp->rx_skbuff[entry],
> > +				pkt_len, rx_copybreak,
> > +				&VORTEX_PCI(vp)->dev, dma, PKT_BUF_SZ);
> > +			if (skb)
> s/if (skb)/if (vp->rx_skbuff[entry])/ probably

For this driver and via-velocity - you're right (fixed). For others no -
they always refill the rx ring, possibly discarding the packet.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html