netdev - Re: [PATCH net-next-2.6 1/2] net: introduce __netdev_alloc_skb_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHXqBFJBt54ksT4D0iee_9GrORzQYkPhmr4ztOH3wxk9rqaJXA@mail.gmail.com>
Date:	Tue, 12 Jul 2011 01:12:21 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6 1/2] net: introduce __netdev_alloc_skb_ip_align

2011/7/12 Ben Hutchings <bhutchings@...arflare.com>:
> On Mon, 2011-07-11 at 23:52 +0200, Eric Dumazet wrote:
>> RX rings should use GFP_KERNEL allocations if possible, add
>> __netdev_alloc_skb_ip_align() helper to ease this.
> [...]
> When it is possible, other than when starting an interface?  RX refill
> normally has to be done in NAPI context or at least synchronised with
> NAPI, so GFP_ATOMIC is required.  Not sure how much point there is in
> making a special case for the initial fill.

Drivers can also refill buffers later, even from separate thread. Ring refilling
can be made lockless given proper access ordering is preserved.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html