netdev - Re: [PATCH net-next-2.6 1/2] net: introduce __netdev_alloc_skb_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110711.193223.1071104458616510178.davem@davemloft.net>
Date:	Mon, 11 Jul 2011 19:32:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 1/2] net: introduce
 __netdev_alloc_skb_ip_align

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 11 Jul 2011 23:57:08 +0100

> On Mon, 2011-07-11 at 23:52 +0200, Eric Dumazet wrote:
>> RX rings should use GFP_KERNEL allocations if possible, add
>> __netdev_alloc_skb_ip_align() helper to ease this.
> [...]
> 
> When it is possible, other than when starting an interface?  RX refill
> normally has to be done in NAPI context or at least synchronised with
> NAPI, so GFP_ATOMIC is required.  Not sure how much point there is in
> making a special case for the initial fill.

There is a point, because if this init case fails you lose the
interface entirely.

Whereas the other cases only cause the loss of a few packets.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html