lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jul 2011 14:46:50 +0530 From: Krishna Kumar <krkumar2@...ibm.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, shemminger@...tta.com, Krishna Kumar <krkumar2@...ibm.com> Subject: [PATCH] Fix panic in virtnet_remove modprobe -r virtio_net panics in free_netdev() as the dev is already freed in the newly introduced virtnet_free (commit 3fa2a1df9094). Since virtnet_remove doesn't require dev after unregister, I am removing the free_netdev call in virtnet_remove instead of in virtnet_free (which seems to be the right place to free the dev). Confirmed that the panic is fixed with this patch. Signed-off-by: Krishna Kumar <krkumar2@...ibm.com> --- drivers/net/virtio_net.c | 2 -- 1 file changed, 2 deletions(-) diff -ruNp org/drivers/net/virtio_net.c new/drivers/net/virtio_net.c --- org/drivers/net/virtio_net.c 2011-07-04 10:38:33.000000000 +0530 +++ new/drivers/net/virtio_net.c 2011-07-15 14:27:48.000000000 +0530 @@ -1121,8 +1121,6 @@ static void __devexit virtnet_remove(str while (vi->pages) __free_pages(get_a_page(vi, GFP_KERNEL), 0); - - free_netdev(vi->dev); } static struct virtio_device_id id_table[] = { -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists