netdev - Re: [RFC 46/72] ixp2000: Move the Radisys driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110715103219.GQ951@wantstofly.org>
Date:	Fri, 15 Jul 2011 12:32:19 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC 46/72] ixp2000: Move the Radisys driver

On Thu, Jul 14, 2011 at 06:19:17PM -0700, Jeff Kirsher wrote:

> > > > > Move the Radisys driver into drivers/net/ethernet/radisys/ and
> > > > > make the necessary Kconfig and Makefile changes
> > > > > 
> > > > > CC: Lennert Buytenhek <kernel@...tstofly.org>
> > > > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > > > > ---
> > > > >  MAINTAINERS                                        |    2 +-
> > > > >  drivers/net/Kconfig                                |    2 --
> > > > >  drivers/net/Makefile                               |    1 -
> > > > >  drivers/net/ethernet/Kconfig                       |    1 +
> > > > >  drivers/net/ethernet/Makefile                      |    1 +
> > > > >  drivers/net/ethernet/radisys/Kconfig               |   16 ++++++++++++++++
> > > > >  drivers/net/ethernet/radisys/Makefile              |    5 +++++
> > > > >  drivers/net/{ => ethernet/radisys}/ixp2000/Kconfig |    2 +-
> > > > >  .../net/{ => ethernet/radisys}/ixp2000/Makefile    |    0
> > > > 
> > > > The ixp2000 is a series of Intel ARM SoCs, and the ENP2611 is a Radisys
> > > > PCI board based on the ixp2000 series (ixp2400), so it doesn't make
> > > > sense to put everything in the radisys/ directory.
> > > 
> > > It was suggested earlier that it probably should be in either ixp/ or
> > > radisys/, and someone suggested that ixp/ might be confusing.  If you
> > > would like to keep it under drivers/net/ethernet/ixp2000, I am fine with
> > > that as well.
> > > 
> > > > If you insist on moving all drivers into vendor directories (I don't
> > > > like that idea at all -- are we going to rename directories and shuffle
> > > > stuff around every time vendor A buys vendor B or takes over one of
> > > > vendor B's products?), at least the core ixp2000 code should be under
> > > > intel/.
> > > 
> > > It was not my preference to place drivers into vendor specific
> > > directories because of that very reason, as I did the work, it just
> > > tended to work out that way.
> > > 
> > > The reason (as stated before) that it was not moved into intel/
> > > directory is because the driver was not written (and supported) by
> > > Intel.
> > 
> > I didn't follow the discussion, but that seems like a silly argument.
> > Does that mean that any non-vendor supported driver can't go into
> > drivers/net/$vendor/?  What if the vendor starts contributing to the
> > driver later on, will the driver be moved then?
> > 
> > It seems that what you're saying is that you don't want the ixp2000
> > driver in "your" subdirectory.
> 
> It is more that all the drivers that in intel/ are all very similar and
> have "common" code which potentially code be shared.  We have been
> looking at what possibilities there are for the common code between the
> Intel supported drivers.  So it really did not make sense to throw a
> driver into the intel/ directory just because it used an Intel chip, but
> has nothing in common with the other drivers in that directory.  Sorry
> if my previous explanation sounded like it I just did not want the
> drivers in the intel/ because we did not write or support it.
> 
> After looking at ixp2000/ixp4xx drivers and the 82586/82596 drivers a
> bit more, I came up with the solution of putting the IXP drivers in
> xscale/ and the 82586/82596 drivers in i825xx/ directory.

That sounds fine with me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html