netdev - Re: [PATCH 03/10] net: add APIs for manipulating skb page fragments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHXqBF+xGAK6o0M0QCkuPKvziDK4Y3ceHVsmbB9tXiN3XX0-Sg@mail.gmail.com>
Date:	Sat, 16 Jul 2011 00:34:36 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Ian Campbell <ian.campbell@...rix.com>
Cc:	netdev@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH 03/10] net: add APIs for manipulating skb page fragments.

2011/7/15 Ian Campbell <ian.campbell@...rix.com>:
[...]
> +static inline dma_addr_t skb_frag_pci_map(struct pci_dev *hwdev,
> +                                         const skb_frag_t *frag,
> +                                         unsigned long offset,
> +                                         size_t size,
> +                                         int direction)
> +
> +{
> +       return pci_map_page(hwdev, __skb_frag_page(frag),
> +                           frag->page_offset + offset, size, direction);
> +}

You can get rid of this one, as drivers should be converted to generic
DMA API instead. The change is only in passing &pci_dev->dev instead
of pci_dev.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html