netdev - problem with function vlan_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <201107171253127340006@gmail.com>
Date:	Sun, 17 Jul 2011 12:53:15 +0800
From:	"jiangtao.jit" <jiangtao.jit@...il.com>
To:	"netdev" <netdev@...r.kernel.org>
Subject: problem with function vlan_get_protocol()

Hi,all

in file   inclue/linux/if_vlan.h

there is a statement in function vlan_get_protocol()

	if (likely(protop))
		protocol = *protop;

do we need an else branch on pointer protop failed ?  through the else is unlikely 

	if (likely(protop))
		protocol = *protop;
    else
		protocol = proto;

is it necessary ?

thanks


2011-07-17 
jiangtao.jit 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html