netdev - Re: [patch net-next-2.6] vlan: introduce ndo_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110717073022.GA2089@minipsycho.orion>
Date:	Sun, 17 Jul 2011 09:30:23 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, eric.dumazet@...il.com,
	greearb@...delatech.com
Subject: Re: [patch net-next-2.6] vlan: introduce ndo_vlan_[enable/disable]

Sat, Jul 16, 2011 at 04:14:36PM CEST, mirqus@...il.com wrote:
>2011/7/16 Jiri Pirko <jpirko@...hat.com>:
>> Some devices are not able to enable/disable rx/tw vlan accel separately.
>> they depend on ndo_vlan_rx_register to know if to enable of disable
>> hw accel. And since ndo_vlan_rx_register is going to die soon,
>> this must be resolved.
>>
>> One solution might be to enable accel on device start every time, even
>> if there are no vlan up on. But this would change behaviour and might
>> lead to possible regression (on older devices).
>[...]
>
>Please describe the possible regression. As I see it, there won't be
>any user visible change of behaviour - network code takes care of
>reinserting VLAN tag when necessary. If you think that disabling tag
>stripping is beneficial for cases where no VLANs are configured, it's
>better to do that in netdev_fix_features() for devices which advertise
>NETIF_F_HW_VLAN_RX in hw_features.

Well I just wanted to preserve current behaviour which is that in many
drivers vlan accel is enabled only if some vid is registered upon the
device and it's disabled again when no vid is registered. I can see
no way to do this with current code after removing ndo_vlan_rx_register.

I expect unexpected problems on old cards when vlan accel would be
enabled all the time, but maybe I'm wrong...

One idea is for device which do not support sepatate rx/tx vlan accel
enabling/disabling they can probably use ndo_fix_features force to 
enable/disable rx/tx pair together. That would resolve the situation as
well giving user possibility to turn off vlan accel in case of any issues.

>
>Best Regards,
>Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html