netdev - Re: [PATCH 13/13] sunrpc: use SKB fragment destructors to delay completion until page is released by network stack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1311359956.13553.8.camel@lade.trondhjem.org>
Date:	Fri, 22 Jul 2011 14:39:16 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Ian Campbell <ian.campbell@...rix.com>
Cc:	netdev@...r.kernel.org, linux-nfs@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Neil Brown <neilb@...e.de>,
	"J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: [PATCH 13/13] sunrpc: use SKB fragment destructors to delay
 completion until page is released by network stack.

On Fri, 2011-07-22 at 14:17 +0100, Ian Campbell wrote: 
> This prevents an issue where an ACK is delayed, a retransmit is queued (either
> at the RPC or TCP level) and the ACK arrives before the retransmission hits the
> wire. If this happens to an NFS WRITE RPC then the write() system call
> completes and the userspace process can continue, potentially modifying data
> referenced by the retransmission before the retransmission occurs.
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Neil Brown <neilb@...e.de>
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: linux-nfs@...r.kernel.org
> Cc: netdev@...r.kernel.org
> [since v1:
>   Push down from NFS layer into RPM layer
> ]
> ---
>  include/linux/sunrpc/xdr.h  |    2 ++
>  include/linux/sunrpc/xprt.h |    5 ++++-
>  net/sunrpc/clnt.c           |   27 ++++++++++++++++++++++-----
>  net/sunrpc/svcsock.c        |    2 +-
>  net/sunrpc/xprt.c           |   13 +++++++++++++
>  net/sunrpc/xprtsock.c       |    2 +-
>  6 files changed, 43 insertions(+), 8 deletions(-)

This looks good to me. Thanks, Ian!

Acked-by: Trond Myklebust <Trond.Myklebust@...app.com>

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html