netdev - RE: [PATCH 09/14] bna: Ethtool Enhancements and Fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86A94D995377@HQ1-EXCH01.corp.brocade.com>
Date:	Tue, 16 Aug 2011 16:26:39 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>,
	Gurunatha Karaje <gkaraje@...cade.com>
Subject: RE: [PATCH 09/14] bna: Ethtool Enhancements and Fix

>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Tuesday, August 16, 2011 2:43 PM
>
>On Tue, 2011-08-16 at 14:19 -0700, Rasesh Mody wrote:
>> Change details:
>>  - Set coalescing time out for multiple tx objects.
>>  - Use bnad_dim_timer_stop macro in bnad_set_coalesce.
>>  - Add tx_skb counters and NAPI debug counters to ethtool stats.
>>  - Add rlb stats strings to bnad_net_stats_strings{} array. rlb_stats
>field
>>    was added to struct bfi_enet_stats {} but the corresponding name
>structure
>>    array for ethtool was not initialized with right strings, even
>though the
>>    actual name structure array got expanded. This caused a NULL
>pointer
>>    violation and a crash when doing ehtool -S <if_name>.
>>  - While setting the ring parameter restore the rx, vlan configuration
>and
>>    set rx mode
>>  - Indentation fix
>>
>> Signed-off-by: Gurunatha Karaje <gkaraje@...cade.com>
>> Signed-off-by: Rasesh Mody <rmody@...cade.com>
>> ---
>>  drivers/net/ethernet/brocade/bna/bnad.c         |   21 +++---
>>  drivers/net/ethernet/brocade/bna/bnad.h         |   10 ++-
>>  drivers/net/ethernet/brocade/bna/bnad_ethtool.c |   88
>+++++++++++++++++++----
>>  3 files changed, 92 insertions(+), 27 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
>b/drivers/net/ethernet/brocade/bna/bnad.c
>> index 11c058e..76bfa19 100644
>> --- a/drivers/net/ethernet/brocade/bna/bnad.c
>> +++ b/drivers/net/ethernet/brocade/bna/bnad.c
>> @@ -2008,12 +2008,15 @@ void
>>  bnad_tx_coalescing_timeo_set(struct bnad *bnad)
>>  {
>>  	struct bnad_tx_info *tx_info;
>> +	int i;
>>
>> -	tx_info = &bnad->tx_info[0];
>> -	if (!tx_info->tx)
>> -		return;
>> -
>> -	bna_tx_coalescing_timeo_set(tx_info->tx, bnad-
>>tx_coalescing_timeo);
>> +	for (i = 0; i < bnad->num_tx; i++) {
>> +		tx_info = &bnad->tx_info[i];
>> +		if (!tx_info->tx)
>> +			continue;
>> +		bna_tx_coalescing_timeo_set(tx_info->tx,
>> +				bnad->tx_coalescing_timeo);
>> +	}
>>  }
>[...]
>
>Doesn't this need to be done at the same time as patch 04/14 "bna: Add
>Multiple Tx Queue Support"?

Ben,
Thanks for the feedback!

Yes, this is Multiple TXQ related change and will move it to 04/14. Since
ethtool is using it, we thought it would make more sense to do this change
with other ethtool changes.

Rasesh