netdev - RE: [PATCH 06/14] bna: TX Path and RX Path Changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86A94D995379@HQ1-EXCH01.corp.brocade.com>
Date:	Tue, 16 Aug 2011 16:28:51 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>,
	Gurunatha Karaje <gkaraje@...cade.com>
Subject: RE: [PATCH 06/14] bna: TX Path and RX Path Changes

>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Tuesday, August 16, 2011 2:46 PM
>
>On Tue, 2011-08-16 at 14:19 -0700, Rasesh Mody wrote:
>> Change details:
>>  - Disable and enable interrupts from the same polling context to
>prevent
>>    reordering in Rx path.
>>  - Add Rx NAPI debug counters.
>>  - Make NAPI budget check more generic
>>  - Add a macro bnad_dim_timer_stop for DIM(Dynamic Interrupt
>Moderation)
>>    timer stop
>>  - Handle reduced MSI-X vectors case in bnad_enable_msix
>>  - Replace existing checks with macros and add more checks for illegal
>skbs
>>    in transmit path. Add more tx_skb counters for dropped skbs.
>>  - Check for single frame TSO skbs and send them out as non-TSO.
>>  - Put memory barrier after bna_txq_prod_indx_doorbell()
>>
>> Signed-off-by: Gurunatha Karaje <gkaraje@...cade.com>
>> Signed-off-by: Rasesh Mody <rmody@...cade.com>
>> ---
>>  drivers/net/ethernet/brocade/bna/bnad.c |  207 +++++++++++++++++-----
>---------
>>  drivers/net/ethernet/brocade/bna/bnad.h |   33 +++++-
>>  2 files changed, 148 insertions(+), 92 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
>b/drivers/net/ethernet/brocade/bna/bnad.c
>> index 64e2106..0faa8a1 100644
>> --- a/drivers/net/ethernet/brocade/bna/bnad.c
>> +++ b/drivers/net/ethernet/brocade/bna/bnad.c
>> @@ -532,7 +532,7 @@ bnad_poll_cq(struct bnad *bnad, struct bna_ccb
>*ccb, int budget)
>>  		      (flags & BNA_CQ_EF_L4_CKSUM_OK)))
>>  			skb->ip_summed = CHECKSUM_UNNECESSARY;
>>  		else
>> -			skb_checksum_none_assert(skb);
>> +			skb->ip_summed = CHECKSUM_NONE;
>>
>>  		rcb->rxq->rx_packets++;
>>  		rcb->rxq->rx_bytes += skb->len;
>[...]
>
>This is reverting part of:
>
>commit bc8acf2c8c3e43fcc192762a9f964b3e9a17748b
>Author: Eric Dumazet <eric.dumazet@...il.com>
>Date:   Thu Sep 2 13:07:41 2010 -0700
>
>    drivers/net: avoid some skb->ip_summed initializations
>
>and I don't see any justification for that.

It is an erroneous change, this change will be dropped when resubmitting
this patch set.
Thanks,
Rasesh