Message-Id: <20110823.161209.503161978488308532.davem@davemloft.net>
Date:	Tue, 23 Aug 2011 16:12:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next 0/9][pull request] Complete drivers/net/ move

From: David Miller <davem@...emloft.net>
Date: Tue, 23 Aug 2011 15:41:57 -0700 (PDT)

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Tue, 23 Aug 2011 01:45:40 -0700
> 
>> The following series moves the FDDI, PPP, HIPPI, PLIP, SLIP and the cleanup
>> of the drivers/net/ Kconfig & Makefile's.  This series in addition moves
>> the 2 remaining drivers in drivers/net/pcmcia/ into their respective
>> directories (arcnet & tokenring).  The last remaining change is to
>> make the all the "new" Kconfig options introduced by the Ethernet
>> drivers move to yes, so that current defconfig's will compile the expected
>> drivers.
>> 
>> The following are changes since commit ca1ba7caa68520864e4b9227e67f3bbc6fed373b:
>>   Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/net-next
>> and are available in the git repository at:
>>   master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/next-organize master
> 
> I pulled this, but because you changed FDDI and these other newly
> moved subsystems from a "config FOO" into a "menuconfig FOO", it now
> prompts for those too during the first oldconfig.

I had to unpull, this breaks the build, see the skfddi errors below.

Also, you can't change "config" into "menuconfig", it makes things
that were previously buildable modular no longer able to be.

include/config/auto.conf:2204:warning: symbol value 'm' invalid for FDDI
include/config/auto.conf:3764:warning: symbol value 'm' invalid for ARCNET
include/config/auto.conf:4044:warning: symbol value 'm' invalid for TR
include/config/auto.conf:4700:warning: symbol value 'm' invalid for PPP
drivers/block/drbd/drbd_main.c: In function ‘drbd_buildtag’:
drivers/block/drbd/drbd_main.c:4187:19: warning: the comparison will always evaluate as ‘true’ for the address of ‘__this_module’ will never be NULL [-Waddress]
drivers/infiniband/hw/mlx4/qp.c: In function ‘build_mlx_header’:
drivers/infiniband/hw/mlx4/qp.c:1387:30: warning: ‘vlan’ may be used uninitialized in this function [-Wuninitialized]
net/dccp/probe.c: In function ‘dccpprobe_init’:
net/dccp/probe.c:166:2: warning: the omitted middle operand in ?: will always be ‘true’, suggest explicit middle operand [-Wparentheses]
drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
drivers/isdn/hardware/mISDN/hfcpci.c:2319:2: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result]
drivers/net/ethernet/amd/nmclan_cs.c: In function ‘nmclan_config’:
drivers/net/ethernet/amd/nmclan_cs.c:628:3: warning: ‘pcmcia_request_exclusive_irq’ is deprecated (declared at include/pcmcia/ds.h:201) [-Wdeprecated-declarations]
In file included from drivers/net/fddi/skfp/skfddi.c:97:0:
drivers/net/fddi/skfp/h/smc.h:41:24: fatal error: h/osdef1st.h: No such file or directory
compilation terminated.
make[4]: *** [drivers/net/fddi/skfp/skfddi.o] Error 1
make[3]: *** [drivers/net/fddi/skfp] Error 2
make[2]: *** [drivers/net/fddi] Error 2
make[2]: *** Waiting for unfinished jobs....
drivers/net/ethernet/broadcom/cnic.c: In function ‘cnic_cm_open’:
drivers/net/ethernet/broadcom/cnic.c:4084:2: warning: the comparison will always evaluate as ‘true’ for the address of ‘cm_ulp_ops’ will never be NULL [-Waddress]
drivers/net/ethernet/i825xx/znet.c: In function ‘hardware_init’:
drivers/net/ethernet/i825xx/znet.c:864:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/i825xx/znet.c:871:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
net/netfilter/nf_conntrack_proto.c: In function ‘nf_conntrack_l3proto_unregister’:
net/netfilter/nf_conntrack_proto.c:210:2: warning: the comparison will always evaluate as ‘true’ for the address of ‘nf_conntrack_l3proto_generic’ will never be NULL [-Waddress]
net/netfilter/nf_conntrack_proto.c: In function ‘nf_conntrack_l4proto_unregister’:
net/netfilter/nf_conntrack_proto.c:345:2: warning: the comparison will always evaluate as ‘true’ for the address of ‘nf_conntrack_l4proto_generic’ will never be NULL [-Waddress]
net/netfilter/nf_conntrack_proto.c: In function ‘nf_conntrack_proto_init’:
net/netfilter/nf_conntrack_proto.c:370:3: warning: the comparison will always evaluate as ‘true’ for the address of ‘nf_conntrack_l3proto_generic’ will never be NULL [-Waddress]
net/sched/sch_generic.c: In function ‘dev_graft_qdisc’:
net/sched/sch_generic.c:678:2: warning: the comparison will always evaluate as ‘true’ for the address of ‘noop_qdisc’ will never be NULL [-Waddress]
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1716:39: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
drivers/staging/bcm/CmHost.c:1752:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
drivers/staging/bcm/CmHost.c:1763:35: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
drivers/staging/bcm/led_control.c: In function ‘LEDControlThread’:
drivers/staging/bcm/led_control.c:789:4: warning: case value ‘255’ not in enumerated type ‘LedEventInfo_t’ [-Wswitch]
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
drivers/staging/cxt1e1/functions.c:275:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/staging/rtl8192e/ieee80211/ieee80211_module.c: In function ‘store_debug_level’:
drivers/staging/rtl8192e/ieee80211/ieee80211_module.c:253:22: warning: comparison of distinct pointer types lacks a cast [enabled by default]
In file included from drivers/staging/wlan-ng/prism2usb.c:5:0:
drivers/staging/wlan-ng/prism2fw.c: In function ‘writeimage.constprop.0’:
drivers/staging/wlan-ng/prism2fw.c:1115:1: warning: the frame size of 4272 bytes is larger than 2048 bytes [-Wframe-larger-than=]
make: *** [drivers] Error 2

Powered by blists - more mailing lists