netdev - Re: [net-next 0/9][pull request] Complete drivers/net/ move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1314153587.2128.242.camel@jtkirshe-mobl>
Date:	Tue, 23 Aug 2011 19:39:47 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: Re: [net-next 0/9][pull request] Complete drivers/net/ move

On Tue, 2011-08-23 at 16:12 -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Tue, 23 Aug 2011 15:41:57 -0700 (PDT)
> 
> > From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > Date: Tue, 23 Aug 2011 01:45:40 -0700
> > 
> >> The following series moves the FDDI, PPP, HIPPI, PLIP, SLIP and the cleanup
> >> of the drivers/net/ Kconfig & Makefile's.  This series in addition moves
> >> the 2 remaining drivers in drivers/net/pcmcia/ into their respective
> >> directories (arcnet & tokenring).  The last remaining change is to
> >> make the all the "new" Kconfig options introduced by the Ethernet
> >> drivers move to yes, so that current defconfig's will compile the expected
> >> drivers.
> >> 
> >> The following are changes since commit ca1ba7caa68520864e4b9227e67f3bbc6fed373b:
> >>   Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/net-next
> >> and are available in the git repository at:
> >>   master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/next-organize master
> > 
> > I pulled this, but because you changed FDDI and these other newly
> > moved subsystems from a "config FOO" into a "menuconfig FOO", it now
> > prompts for those too during the first oldconfig.
> 
> I had to unpull, this breaks the build, see the skfddi errors below.
> 
> Also, you can't change "config" into "menuconfig", it makes things
> that were previously buildable modular no longer able to be.
> 
> include/config/auto.conf:2204:warning: symbol value 'm' invalid for FDDI
> include/config/auto.conf:3764:warning: symbol value 'm' invalid for ARCNET
> include/config/auto.conf:4044:warning: symbol value 'm' invalid for TR
> include/config/auto.conf:4700:warning: symbol value 'm' invalid for PPP

Grrr, I did not see or find any reason for FDDI, ARCNET, Tokenring or
PPP to loaded as a module.  That was the reason for the change, sorry.

I was seeing the Group Heading for these technologies as just that,
headers (like Ethernet).  I will revert that change.

I will also fix up the new Kconfig options like I did for the new
Ethernet Kconfig options.  (default y).



Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)