lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Aug 2011 09:13:43 -0700 From: "Vladislav Zolotarov" <vladz@...adcom.com> To: "Michal Schmidt" <mschmidt@...hat.com> cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Dmitry Kravkov" <dmitry@...adcom.com>, "Eilon Greenstein" <eilong@...adcom.com>, "mirqus@...il.com" <mirqus@...il.com> Subject: RE: [PATCH 1/3] bnx2x: remove TPA_ENABLE_FLAG > -----Original Message----- > From: Michal Schmidt [mailto:mschmidt@...hat.com] > Sent: Wednesday, August 31, 2011 6:59 PM > To: Vladislav Zolotarov > Cc: netdev@...r.kernel.org; Dmitry Kravkov; Eilon Greenstein; > mirqus@...il.com > Subject: Re: [PATCH 1/3] bnx2x: remove TPA_ENABLE_FLAG > > On Wed, 31 Aug 2011 18:16:30 +0300 Vlad Zolotarov wrote: > > On Wednesday 31 August 2011 18:00:34 Michal Schmidt wrote: > > > if (bnx2x_reload) { > > > - if (bp->recovery_state == BNX2X_RECOVERY_DONE) > > > + if (bp->recovery_state == BNX2X_RECOVERY_DONE) { > > > + /* > > > + * Cheat! Normally dev->features will be > > > set after we > > > + * return, but that's too late. We need to > > > know how to > > > + * configure the NIC when reloading it, so > > > update > > > + * the features early. > > > + */ > > > + dev->features = features; > > > return bnx2x_reload_if_running(dev); > > > > NACK > > > > This is bogus - what if bnx2x_reload_if_running(dev) > > (bnx2x_nic_load()) failes? The original dev->features would be > > lost... > > Well, yes, but since the NIC would be now not working, do we really > care about its features? :-) U r kidding, right? ;) We care about the consistency in the netdev features state - if we failed to configure the requested feature and returned an error on e.g. "ethtool -K ethX lro on" call, it's expected that a subsequent ethtool -k ethX call won't report the requested feature (LRO) as set. Thanks, vlad > > Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists