netdev - Re: [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110921120341.GG28907@S2100-06.ap.freescale.net>
Date:	Wed, 21 Sep 2011 20:03:42 +0800
From:	Shawn Guo <shawn.guo@...escale.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	Shawn Guo <shawn.guo@...aro.org>,
	"David S. Miller" <davem@...emloft.net>, <patches@...aro.org>,
	<netdev@...r.kernel.org>,
	Troy Kisky <troy.kisky@...ndarydevices.com>,
	Francois Romieu <romieu@...zoreil.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Lothar Waßmann <LW@...O-electronics.de>
Subject: Re: [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to
 debug message

On Wed, Sep 21, 2011 at 01:25:55PM +0200, Wolfram Sang wrote:
> Hi Shawn,
> 
> On Wed, Sep 21, 2011 at 07:10:30PM +0800, Shawn Guo wrote:
> > FEC can work without a phy reset on some platforms, which means not
> > very platform necessarily have a phy-reset gpio encoded in device tree.
> > So it makes more sense to have the phy-reset-gpio request failure as
> > a debug message rather than a warning.
> 
> Or remove it entirely?
> 
I would like to keep it.  When people want to debug at this point, they
do not need to type the debug message.

> > 
> > Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
> > ---
> >  drivers/net/ethernet/freescale/fec.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> > index 158b82e..a057abf 100644
> > --- a/drivers/net/ethernet/freescale/fec.c
> > +++ b/drivers/net/ethernet/freescale/fec.c
> > @@ -1422,7 +1422,7 @@ static int __devinit fec_reset_phy(struct platform_device *pdev)
> >  	phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
> >  	err = gpio_request_one(phy_reset, GPIOF_OUT_INIT_LOW, "phy-reset");
> >  	if (err) {
> > -		pr_warn("FEC: failed to get gpio phy-reset: %d\n", err);
> > +		pr_debug("FEC: failed to get gpio phy-reset: %d\n", err);
> >  		return err;
> 
> I also wanted to suggested to drop returning the error code, since it is
> not an error anymore, strictly speaking. Then I noticed that the caller
> does not check the error code. So, this could be added or turn the
> function to void?
> 
To me, keep the return value as integer is more scalable.  Someday,
someone need to add more stuff in the function, or want to improve
the caller to check return value, it plays.

Regards,
Shawn

> >  	}
> >  	msleep(1);
> > -- 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html