netdev - Re: [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110921131838.GJ28907@S2100-06.ap.freescale.net>
Date:	Wed, 21 Sep 2011 21:18:39 +0800
From:	Shawn Guo <shawn.guo@...escale.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	<patches@...aro.org>, <netdev@...r.kernel.org>,
	Troy Kisky <troy.kisky@...ndarydevices.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	Lothar Waßmann <LW@...O-electronics.de>
Subject: Re: [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to
 debug message

On Wed, Sep 21, 2011 at 02:59:05PM +0200, Wolfram Sang wrote:
> > > I agree that keeping it int is way better. But why not add it now to
> > > keep things proper and tested? If this patch gets accepted as it is and
> > > later someone else will add error checking to the caller, your platform
> > > will lose FEC support as a regression.
> > > 
> > Again, fec_reset_phy() failure is not a show-stopper.  We might not
> > want to make the probe fail because of that.
> 
> That would be an argument to make the function returning void?
> 
Hmm, it seems to be.  Ok, will send v3 to return void.

Regards,
Shawn

> Well, I still think something like 
> 
> 	/* No phy reset configured */
> 	if (phy_reset == -ENODEV)
> 		return 0;
> 
> might be cleaner, yet I don't have the setup to test such an approach.
> 
> So, I'll be quiet now and hope for no problems.
> 
> -- 
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html