netdev - Re: [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110927.013247.336618301904552114.davem@davemloft.net>
Date:	Tue, 27 Sep 2011 01:32:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jonathan@....us
Cc:	venkat.x.venkatsubra@...cle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr_pool

From: Jonathan Lallinger <jonathan@....us>
Date: Tue, 13 Sep 2011 14:41:01 -0500

> @@ -548,6 +550,7 @@ static int rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all)
>  		spin_unlock_irqrestore(&pool->list_lock, flags);
>  	}
>  
> +	atomic_sub(unpinned, &poll->free_pinned);
>  	atomic_sub(ncleaned, &pool->dirty_count);
>  	atomic_sub(nfreed, &pool->item_count);
>  

net/rds/iw_rdma.c: In function ‘rds_iw_flush_mr_pool’:
net/rds/iw_rdma.c:553:24: error: ‘poll’ undeclared (first use in this function)
net/rds/iw_rdma.c:553:24: note: each undeclared identifier is reported only once for each function it appears in

If you didn't even build test it, I know you didn't test it's
functionality either.

This is crazy.

Well if it's not important enough to even build test this change
before you post it, then it obviously doesn't matter if the RDMA
module crashes the kernel when it's unloaded.