netdev - Re: [PATCH] net: xen-netback: correctly restart Tx after a VM restore/migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111003.141603.369934124561797426.davem@davemloft.net>
Date:	Mon, 03 Oct 2011 14:16:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Ian.Campbell@...citrix.com
Cc:	david.vrabel@...rix.com, netdev@...r.kernel.org,
	xen-devel@...ts.xensource.com
Subject: Re: [PATCH] net: xen-netback: correctly restart Tx after a VM
 restore/migrate

From: Ian Campbell <Ian.Campbell@...citrix.com>
Date: Fri, 30 Sep 2011 17:45:05 +0100

> On Fri, 2011-09-30 at 17:37 +0100, David Vrabel wrote:
>> If a VM is saved and restored (or migrated) the netback driver will no
>> longer process any Tx packets from the frontend.  xenvif_up() does not
>> schedule the processing of any pending Tx requests from the front end
>> because the carrier is off.  Without this initial kick the frontend
>> just adds Tx requests to the ring without raising an event (until the
>> ring is full).
>> 
>> This was caused by 47103041e91794acdbc6165da0ae288d844c820b (net:
>> xen-netback: convert to hw_features) which reordered the calls to
>> xenvif_up() and netif_carrier_on() in xenvif_connect().
> 
> Ah, so the bit of that patch which moved "netif_carrier_on(vif->dev);"
> should have actually moved the entire block
>  	netif_carrier_on(vif->dev);
> 	if (netif_running(vif->dev))
> 		xenvif_up(vif);
> 
> Since it it is logically a single thing. Make sense. Thanks!
> 
>> Signed-off-by: David Vrabel <david.vrabel@...rix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@...rix.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html