netdev - Re: [PATCH 2/2] IPVS netns shutdown/startup dead-lock (Take III)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111004211554.GB11987@verge.net.au>
Date:	Wed, 5 Oct 2011 06:15:55 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Julian Anastasov <ja@....bg>
Cc:	Hans Schillstrom <hans.schillstrom@...csson.com>,
	wensong@...ux-vs.org, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	hans@...illstrom.com
Subject: Re: [PATCH 2/2] IPVS netns shutdown/startup dead-lock (Take III)

On Tue, Oct 04, 2011 at 10:40:29AM +0300, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Tue, 4 Oct 2011, Hans Schillstrom wrote:
> 
> > From: Hans Schillstrom <hans@...illstrom.com>
> > 
> > ip_vs_mutext is used by both netns shutdown code and startup
> > and both implicit uses sk_lock-AF_INET mutex.
> > 
> > cleanup CPU-1         startup CPU-2
> > ip_vs_dst_event()     ip_vs_genl_set_cmd()
> >  sk_lock-AF_INET     __ip_vs_mutex
> >                      sk_lock-AF_INET
> > __ip_vs_mutex
> > * DEAD LOCK *
> > 
> > A new mutex placed in ip_vs netns struct called sync_mutex is added.
> > 
> > Comments from Julian and Simon added.
> > This patch has been running for more than 3 month now and it seems to work.
> > 
> > Ver. 3
> >     IP_VS_SO_GET_DAEMON in do_ip_vs_get_ctl protected by sync_mutex
> >     instead of __ip_vs_mutex as sugested by Julian.
> > 
> > Signed-off-by: Hans Schillstrom <hans@...illstrom.com>
> 
> 	Looks good to me, with one extra empty line in
> start_sync_thread
> 
> Acked-by: Julian Anastasov <ja@....bg>

Thanks, I will apply this change.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html