netdev - Re: e100 + VLANs?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318334674.2538.6.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 11 Oct 2011 14:04:34 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	David Lamparter <equinox@...c24.net>, jeffrey.t.kirsher@...el.com,
	netdev <netdev@...r.kernel.org>
Subject: Re: e100 + VLANs?

Le mardi 11 octobre 2011 à 15:59 +0400, Michael Tokarev a écrit :

> Hmm.  This does not _exactly_ work.
> 
> I applied it on top of 2.6.32, patch applied but with some fuzz - I checked
> manually and it appears to be ok.
> 
> Now, with this patch applied, I see on the e100 side:
> 
> 00:1f:c6:ef:e5:1b > 00:90:27:30:6d:1c, ethertype 802.1Q (0x8100), length 1504: vlan 6, p 0, ethertype IPv4, truncated-ip - 1 bytes missing! (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 1487)
>     10.48.6.1 > 10.48.6.2: ICMP echo request, id 27613, seq 6, length 1467
> 
> when pinging it with -s 1459 (1487 total size).
> 
> I added extra +40 for RFD_BUF_LEN define and recompiled
> (this resulted in RFD_BUF_LEN=1560, - I've added a printk
> just to be sure).
> 
> Now I see the same effect as before the patch:  maximum
> packet size that goes and can be seen on the e100 side
> is 1468(1496) (ping), which results in this on e100 side:
> 
> 15:54:44.830941 00:1f:c6:ef:e5:1b > 00:90:27:30:6d:1c, ethertype 802.1Q (0x8100), length 1514: vlan 6, p 0, ethertype IPv4, (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 1496)
>     10.48.6.1 > 10.48.6.2: ICMP echo request, id 28735, seq 4, length 1476
> 15:54:44.831025 00:90:27:30:6d:1c > 00:1f:c6:ef:e5:1b, ethertype 802.1Q (0x8100), length 1514: vlan 6, p 0, ethertype IPv4, (tos 0x0, ttl 64, id 12010, offset 0, flags [none], proto ICMP (1), length 1496)
>     10.48.6.2 > 10.48.6.1: ICMP echo reply, id 28735, seq 4, length 1476
> 
> (and it works).  With -s 1469, no ICMP packets can be seen
> on e100 side.
> 
> So it still may be the hardware... :)

Yes, my patch was not needed, I was not sure sizeof(struct rfd) was
included or not in the rfd.size setting (apparently its not needed)

Any counters increase in "ethtool -S eth0" ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html