netdev - Re: about phonet pipe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3025840.a3oI7lSnik@leon.remlab.net>
Date:	Wed, 12 Oct 2011 10:58:05 +0300
From:	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
To:	ext Hemant-vilas RAMDASI <hemant.ramdasi@...ricsson.com>
Cc:	Srinidhi KASAGAR <srinidhi.kasagar@...ricsson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: about phonet pipe controller

Le Mercredi 12 Octobre 2011 09:25:01 ext Hemant-vilas RAMDASI a écrit :
> You have mentioned in the
> "a015f6f: Phonet: kill the ST-Ericsson pipe controller Kconfig",
> that "Support for manually enabling the pipe flow is removed as it
> did not work properly, does not fit well with the socket API, and
> I am not aware of any use at the moment.."
> 
> On STE U8500 modem, you must first create pipe in disabled state, then do
> local link configuration (does't work when pipe is enabled) & then enable
> pipe.

The Kconfig option broke support for existing hardware (Nokia N900 as a USB 
gadget) and userspace (namely the oFono ISI driver). We cannot expect 
distributions to provide two different kernel builds for different flavors of ISI 
modems.

> Because of this connect() cannot be used anymore and it needs to be modified
> to reintroduce pipe-controller functionality again.

As far as I can tell, that code NEVER worked properly. Not only the use of a 
build-time option is inappropriate, but the code did not deal with a number of 
new corner cases that it introduced.

> Do you have any suggestions?

I'm sorry but I don't really get where you're trying to get. The code had more 
bugs than I could fix by myself, especially when I don't have the hardware and 
the specification.

-- 
Rémi Denis-Courmont
http://www.remlab.net/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html