netdev - RE: about phonet pipe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81C3A93C17462B4BBD7E272753C105791EAACAEA43@EXDCVYMBSTM005.EQ1STM.local>
Date:	Wed, 12 Oct 2011 12:58:08 +0200
From:	Hemant-vilas RAMDASI <hemant.ramdasi@...ricsson.com>
To:	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
Cc:	Srinidhi KASAGAR <srinidhi.kasagar@...ricsson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: about phonet pipe controller

Hi,

> -----Original Message-----
> From: Rémi Denis-Courmont [mailto:remi.denis-courmont@...ia.com]
> Sent: Wednesday, October 12, 2011 1:28 PM
> To: Hemant-vilas RAMDASI
> Cc: Srinidhi KASAGAR; netdev@...r.kernel.org
> Subject: Re: about phonet pipe controller
> 
> Le Mercredi 12 Octobre 2011 09:25:01 ext Hemant-vilas RAMDASI a écrit :
> > You have mentioned in the
> > "a015f6f: Phonet: kill the ST-Ericsson pipe controller Kconfig",
> > that "Support for manually enabling the pipe flow is removed as it
> > did not work properly, does not fit well with the socket API, and
> > I am not aware of any use at the moment.."
> >
> > On STE U8500 modem, you must first create pipe in disabled state,
> then do
> > local link configuration (does't work when pipe is enabled) & then
> enable
> > pipe.
> 
> The Kconfig option broke support for existing hardware (Nokia N900 as a
> USB
> gadget) and userspace (namely the oFono ISI driver). We cannot expect
> distributions to provide two different kernel builds for different
> flavors of ISI
> modems.
> 
> > Because of this connect() cannot be used anymore and it needs to be
> modified
> > to reintroduce pipe-controller functionality again.
> 
> As far as I can tell, that code NEVER worked properly. Not only the use
> of a
> build-time option is inappropriate, but the code did not deal with a
> number of
> new corner cases that it introduced.
> 
Yes, I agree that build-time option is not required..But what are those corner cases?

> > Do you have any suggestions?
> 
> I'm sorry but I don't really get where you're trying to get. The code
> had more
> bugs than I could fix by myself, especially when I don't have the
> hardware and
> the specification.
>
As far as I know, connect() API was not there initially. It was implemented as part 
of pipe-controller after your feedback.
We would like to modify connect to create pipe in disabled mode and enable it in 
setsockopt call. 
Basically the problem with current implementation is that there is no way today for 
anyone to disable/enable pipe.

Regards,
Hemant
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html