netdev - Re: [patch net-2.6] tg3: negate USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111012235501.GA31550@mcarlson.broadcom.com>
Date:	Wed, 12 Oct 2011 16:55:01 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Jiri Pirko" <jpirko@...hat.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"Matthew Carlson" <mcarlson@...adcom.com>,
	"Michael Chan" <mchan@...adcom.com>
Subject: Re: [patch net-2.6] tg3: negate USE_PHYLIB flag check

On Wed, Oct 12, 2011 at 02:00:41AM -0700, Jiri Pirko wrote:
> USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
> results tg3_phy_fini->phy_disconnect is never called and when tg3 module
> is removed.
> 
> In my case this resulted in panics in phy_state_machine calling function
> phydev->adjust_link.
> 
> So correct this check.
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Introduced by commit 63c3a66fe6c827a731dcbdee181158b295626f83, entitled
"tg3: Convert u32 flag,flg2,flg3 uses to bitmap".

Acked-by: Matt Carlson <mcarlson@...adcom.com>

> ---
>  drivers/net/tg3.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 4a1374d..c11a2b8 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -15577,7 +15577,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)
>  
>  		cancel_work_sync(&tp->reset_task);
>  
> -		if (!tg3_flag(tp, USE_PHYLIB)) {
> +		if (tg3_flag(tp, USE_PHYLIB)) {
>  			tg3_phy_fini(tp);
>  			tg3_mdio_fini(tp);
>  		}
> -- 
> 1.7.6.2
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html