netdev - Re: [patch net-2.6] tg3: negate USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111019.000005.1573013340632702918.davem@davemloft.net>
Date:	Wed, 19 Oct 2011 00:00:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	jpirko@...hat.com, netdev@...r.kernel.org, eric.dumazet@...il.com,
	mchan@...adcom.com
Subject: Re: [patch net-2.6] tg3: negate USE_PHYLIB flag check

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Wed, 12 Oct 2011 16:55:01 -0700

> On Wed, Oct 12, 2011 at 02:00:41AM -0700, Jiri Pirko wrote:
>> USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
>> results tg3_phy_fini->phy_disconnect is never called and when tg3 module
>> is removed.
>> 
>> In my case this resulted in panics in phy_state_machine calling function
>> phydev->adjust_link.
>> 
>> So correct this check.
>> 
>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
> 
> Introduced by commit 63c3a66fe6c827a731dcbdee181158b295626f83, entitled
> "tg3: Convert u32 flag,flg2,flg3 uses to bitmap".
> 
> Acked-by: Matt Carlson <mcarlson@...adcom.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html