netdev - Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Oct 2011 03:48:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand_head

From: roy.qing.li@...il.com
Date: Fri, 14 Oct 2011 15:39:30 +0800

> when pskb_expand_head reallocates header of &sk_buff, the sk
> truesize should be updated simultaneously
> 
> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>

I know you did not test this patch at all.

You can't modify the truesize because packets passed to this routine
are often attached to a socket, thus if you change the truesize the
socket memory accouting will be adjusted incorrectly later when the
SKB is freed up.

Most SKB modifying functions have to operate with this restriction.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html