netdev - Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318578829.2533.100.camel@edumazet-laptop>
Date:	Fri, 14 Oct 2011 09:53:49 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand_head

Le vendredi 14 octobre 2011 à 15:39 +0800, roy.qing.li@...il.com a
écrit :
> when pskb_expand_head reallocates header of &sk_buff, the sk
> truesize should be updated simultaneously
> 
> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>
> ---
>  net/core/skbuff.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 387703f..48e0be9 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -920,6 +920,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
>  	}
>  	off = (data + nhead) - skb->head;
>  
> +	skb->truesize += (size - (skb_end_pointer(skb) - skb->head));
>  	skb->head     = data;
>  adjust_others:
>  	skb->data    += off;

I dont believe this is needed or complete patch.

Callers that need an updated truesize do the adjustement.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html