netdev - RE: [PATCH] smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Oct 2011 17:28:08 +0200
From:	Robert MARKLUND <robert.marklund@...ricsson.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirer <mathieu.poirier@...aro.org>
Subject: RE: [PATCH] smsc911x: Add regulator support

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: den 17 oktober 2011 16:34
> To: Robert MARKLUND
> Cc: netdev@...r.kernel.org; Steve Glendinning; Mathieu Poirer
> Subject: Re: [PATCH] smsc911x: Add regulator support
> 
> On Mon, Oct 17, 2011 at 04:13:47PM +0200, Robert MARKLUND wrote:
> 
> > > You should fix your mail client to word wrap within paragraphs, I've
> > > reformatted it for legibility.  Also leave a blank line between
> > > paragraphs for the same reason.
> 
> > I have tried but it's not as easy as it sounds :)
> > Does it look better now ?
> 
> Yes, thanks.
> 
> > > No, you should do what all the other drivers do and actually pay
> > > attention to the errors.  If we can't get power to the device that's a
> > > pretty serious problem and the driver ought  to fail.
> 
> > Then I don't understand the initial comment.
> > Can you please elaborate that one.
> 
> If we fail to grab a critical resource for the device like the power
> supply then we should be failing passing the error back.  As I keep
> saying this is what all the other regulator consumers are doing.

Most of the boards out there don't have any regulators for the chip(power is always on).
So when we can't get the regulator, we assume that the power is already on.
That's why it hasn't been implemented before.

So adding this functionality will make all the other boards out there fail, to start the driver.

/R
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html