netdev - Re: [PATCH] smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Oct 2011 16:38:02 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Robert MARKLUND <robert.marklund@...ricsson.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirer <mathieu.poirier@...aro.org>
Subject: Re: [PATCH] smsc911x: Add regulator support

On Mon, Oct 17, 2011 at 05:28:08PM +0200, Robert MARKLUND wrote:

> > If we fail to grab a critical resource for the device like the power
> > supply then we should be failing passing the error back.  As I keep
> > saying this is what all the other regulator consumers are doing.

> Most of the boards out there don't have any regulators for the chip(power is always on).
> So when we can't get the regulator, we assume that the power is already on.
> That's why it hasn't been implemented before.

> So adding this functionality will make all the other boards out there fail, to start the driver.

Clearly this issue is going to apply to every single user of the
regulator API which is one reason why it's insane to open code handling
of missing regulators in individual regulator consumer drivers.  As I
keep saying you should unconditionally use the regulators and let the
regulator API facilities for stubbing itself out deal with this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html