[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 24 Oct 2011 07:57:25 +0200
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Roopa Prabhu <roprabhu@...co.com>
Cc: netdev@...r.kernel.org, sri@...ibm.com, dragos.tatulea@...il.com,
arnd@...db.de, kvm@...r.kernel.org, davem@...emloft.net,
mchan@...adcom.com, dwang2@...co.com, shemminger@...tta.com,
eric.dumazet@...il.com, kaber@...sh.net, benve@...co.com
Subject: Re: [net-next-2.6 PATCH 7/8 RFC v2] macvtap: Add support to set
MAC/VLAN filter rtnl link operations
On Tue, Oct 18, 2011 at 11:26:30PM -0700, Roopa Prabhu wrote:
> From: Roopa Prabhu <roprabhu@...co.com>
>
> This patch adds support to set MAC and VLAN filter rtnl_link_ops
> on a macvtap interface. It adds support for set_rx_addr_filter and
> set_rx_vlan_filter rtnl link operations. These operations inturn call the
> equivalent operations defined in macvlan
>
> Signed-off-by: Roopa Prabhu <roprabhu@...co.com>
> Signed-off-by: Christian Benvenuti <benve@...co.com>
> Signed-off-by: David Wang <dwang2@...co.com>
> ---
> drivers/net/macvtap.c | 22 ++++++++++++++++++----
> 1 files changed, 18 insertions(+), 4 deletions(-)
>
>
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> index 3da5578..8a2cb59 100644
> --- a/drivers/net/macvtap.c
> +++ b/drivers/net/macvtap.c
> @@ -273,6 +273,18 @@ static int macvtap_receive(struct sk_buff *skb)
> return macvtap_forward(skb->dev, skb);
> }
>
> +static int macvtap_set_rx_addr_filter(struct net_device *dev,
> + struct nlattr *tb[])
> +{
> + return macvlan_set_rx_addr_filter(dev, tb);
> +}
> +
> +static int macvtap_set_rx_vlan_filter(struct net_device *dev,
> + struct nlattr *tb[])
> +{
> + return macvlan_set_rx_vlan_filter(dev, tb);
> +}
> +
> static int macvtap_newlink(struct net *src_net,
> struct net_device *dev,
> struct nlattr *tb[],
Can use macvlanXXX directly here? Why wrap it?
> @@ -317,10 +329,12 @@ static void macvtap_setup(struct net_device *dev)
> }
>
> static struct rtnl_link_ops macvtap_link_ops __read_mostly = {
> - .kind = "macvtap",
> - .setup = macvtap_setup,
> - .newlink = macvtap_newlink,
> - .dellink = macvtap_dellink,
> + .kind = "macvtap",
> + .setup = macvtap_setup,
> + .newlink = macvtap_newlink,
> + .dellink = macvtap_dellink,
> + .set_rx_addr_filter = macvtap_set_rx_addr_filter,
> + .set_rx_vlan_filter = macvtap_set_rx_vlan_filter,
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists