netdev - Re: [PATCH] vlan: Don't propagate flag changes on down interfaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111101.175113.2141024983069963090.davem@davemloft.net>
Date:	Tue, 01 Nov 2011 17:51:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	matthijs@...in.nl
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] vlan: Don't propagate flag changes on down interfaces.

From: Matthijs Kooijman <matthijs@...in.nl>
Date: Mon, 31 Oct 2011 15:53:13 +0100

> When (de)configuring a vlan interface, the IFF_ALLMULTI ans IFF_PROMISC
> flags are cleared or set on the underlying interface. So, if these flags
> are changed on a vlan interface that is not up, the flags underlying
> interface might be set or cleared twice.
> 
> Only propagating flag changes when a device is up makes sure this does
> not happen. It also makes sure that an underlying device is not set to
> promiscuous or allmulti mode for a vlan device that is down.
> 
> Signed-off-by: Matthijs Kooijman <matthijs@...in.nl>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html