netdev - Re: [PATCH] neigh: print nud_state in neigh timer handler.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111101.174411.1200019350687608200.davem@davemloft.net>
Date:	Tue, 01 Nov 2011 17:44:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dbaluta@...acom.com
Cc:	eric.dumazet@...il.com, gregory.v.rose@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	daniel.baluta@...il.com
Subject: Re: [PATCH] neigh: print nud_state in neigh timer handler.

From: Daniel Baluta <dbaluta@...acom.com>
Date: Mon, 31 Oct 2011 23:10:48 +0200

> From: Daniel Baluta <daniel.baluta@...il.com>
> 
> For debugging purposes it is useful to know the exact state of a
> non NUD_IN_TIMER neighbour entry whose timer handler just expired.
> 
> Signed-off-by: Daniel Baluta <dbaluta@...acom.com>

This debugging log message is dubious.

Also, it is protected by !SMP and I can almost guarentee you that whatever
condition makes it happen leigitmately on SMP also can be triggered with
preemption enabled on !SMP.

So I'm going to simply remove this debug message entirely instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html