lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Nov 2011 00:05:50 +0200 From: Daniel Baluta <dbaluta@...acom.com> To: David Miller <davem@...emloft.net> Cc: eric.dumazet@...il.com, gregory.v.rose@...el.com, jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org Subject: Re: [PATCH] neigh: print nud_state in neigh timer handler. On Tue, Nov 1, 2011 at 11:44 PM, David Miller <davem@...emloft.net> wrote: > From: Daniel Baluta <dbaluta@...acom.com> > Date: Mon, 31 Oct 2011 23:10:48 +0200 > >> From: Daniel Baluta <daniel.baluta@...il.com> >> >> For debugging purposes it is useful to know the exact state of a >> non NUD_IN_TIMER neighbour entry whose timer handler just expired. >> >> Signed-off-by: Daniel Baluta <dbaluta@...acom.com> > > This debugging log message is dubious. > > Also, it is protected by !SMP and I can almost guarentee you that whatever > condition makes it happen leigitmately on SMP also can be triggered with > preemption enabled on !SMP. > > So I'm going to simply remove this debug message entirely instead. Agree. If you can figure out when this condition is true, it is nice to have a comment. Daniel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists