netdev - Re: [PATCH net-next v1] net-forcedeth: Add internal loopback support for forcedeth NICs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111111.202807.1335209533396648252.davem@davemloft.net>
Date:	Fri, 11 Nov 2011 20:28:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	horti@...gle.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	david.decotigny@...gle.com, ian.campbell@...rix.com,
	rick.jones2@...com, eric.dumazet@...il.com, maheshb@...gle.com
Subject: Re: [PATCH net-next v1] net-forcedeth: Add internal loopback
 support for forcedeth NICs.

From: Sanjay Hortikar <horti@...gle.com>
Date: Wed,  9 Nov 2011 12:45:25 -0800

> @@ -5124,6 +5266,12 @@ static int nv_open(struct net_device *dev)
>  
>  	spin_unlock_irq(&np->lock);
>  
> +	/* If the loopback feature was set while the device was down, make sure
> +	* that it's set correctly now.
> +	*/

Improperly formatted comment, it should be:

	/*
	 *
	 */

> @@ -5328,6 +5476,10 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
>  
>  	dev->features |= dev->hw_features;
>  
> +	/* Add loopback capability to the device. */
> +	dev->hw_features |= NETIF_F_LOOPBACK;
> +
> +
>  	np->pause_flags = NV_PAUSEFRAME_RX_CAPABLE | NV_PAUSEFRAME_RX_REQ | NV_PAUSEFRAME_AUTONEG;

Please do not add all of these extra empty lines.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html