netdev - Re: [PATCH] net, bridge: print log message after state changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117144023.06c8502e@nehalam.linuxnetplumber.net>
Date:	Thu, 17 Nov 2011 14:40:23 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Lamparter <equinox@...c24.net>
Cc:	David Miller <davem@...emloft.net>, Wolfgang.Fritz@...mile.com,
	holger.brunck@...mile.com, netdev@...r.kernel.org,
	shemminger@...ux-foundation.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH] net, bridge: print log message after state changed

On Thu, 17 Nov 2011 20:23:53 +0100
David Lamparter <equinox@...c24.net> wrote:

> There seems to be a misunderstanding here. The patch effectively does:
> -       br_log_state(p);
>         p->state = BR_STATE_DISABLED;
> +       br_log_state(p);
> 
> and the issue it is trying to fix is not the timing but rather the code
> printing the wrong (old, now-left) state.
> 
> I do agree that the log message should be printed before anything
> happens, so, Holger, can you brew a patch that does that?

Other than being horribly strict, why bother? I hope you aren't building
some application that depends on the ordering of the log message.
The state change doesn't get undone, why does the order of the message
matter at all?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html