netdev - Re: [PATCH] bonding: Don't allow mode change via sysfs with slaves present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EC58C89.7020906@gmail.com>
Date:	Thu, 17 Nov 2011 23:36:57 +0100
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	vfalico@...hat.com, netdev@...r.kernel.org, andy@...yhouse.net,
	fubar@...ibm.com
Subject: Re: [PATCH] bonding: Don't allow mode change via sysfs with slaves
 present

Le 17/11/2011 22:04, David Miller a écrit :
> From: Veaceslav Falico<vfalico@...hat.com>
> Date: Tue, 15 Nov 2011 17:44:42 +0100
>
>> When changing mode via bonding's sysfs, the slaves are not initialized
>> correctly. Forbid to change modes with slaves present to ensure that every
>> slave is initialized correctly via bond_enslave().
>>
>> Signed-off-by: Veaceslav Falico<vfalico@...hat.com>
>
> Lots of discussion... what is the final verdict on this patch bonding folks?

Now looks good to me, and as all others participants agreed at the beginning, I think it's good for 
everyone.

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html