[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1322220862.1908.79.camel@mojatatu>
Date: Fri, 25 Nov 2011 06:34:22 -0500
From: jamal <hadi@...erus.ca>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: David Miller <davem@...emloft.net>, shemminger@...tta.com,
jesse@...ira.com, netdev@...r.kernel.org, dev@...nvswitch.org,
chrisw@...hat.com, herbert@...dor.hengli.com.au,
john.r.fastabend@...el.com, jpettit@...ira.com,
Florian Westphal <fw@...len.de>
Subject: Re: Open vSwitch Design
Hrm. I forgot about the flow classifier - it may be what the openflow
folks need. It is more friendly for the well defined tuples than u32.
But what do you mean "refactor"? I can already use this classifier
and attach actions to set policy in the kernel.
cheers,
jamal
On Fri, 2011-11-25 at 07:36 +0100, Eric Dumazet wrote:
> > >
> > > Maybe its time to factorize the thing, eventually use it in a third
> > > component (Open vSwitch...)
> >
> > Yes.
>
> A third reason to do that anyway is that net/sched/sch_sfb.c should use
> __skb_get_rxhash() providing the perturbation itself, and not use the
> standard (hashrnd) one ).
>
> Right now, if two flows share same rxhash, the double SFB hash will also
> share the same final hash.
>
> (This point was mentioned by Florian Westphal)
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists