netdev - Re: Open vSwitch Design

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322226171.2403.14.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Fri, 25 Nov 2011 14:02:51 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	jhs@...atatu.com
Cc:	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	jesse@...ira.com, netdev@...r.kernel.org, dev@...nvswitch.org,
	chrisw@...hat.com, herbert@...dor.hengli.com.au,
	john.r.fastabend@...el.com, jpettit@...ira.com,
	Florian Westphal <fw@...len.de>
Subject: Re: Open vSwitch Design

Le vendredi 25 novembre 2011 à 06:34 -0500, jamal a écrit :
> Hrm. I forgot about the flow classifier - it may be what the openflow
> folks need. It is more friendly for the well defined tuples than u32.
> 
> But what do you mean "refactor"? I can already use this classifier
> and attach actions to set policy in the kernel.

cls_flow is not complete, since it doesnt handle tunnels for example.

It calls a 'partial flow classifier' to find each needed element, one by
one.
(adding tunnel decap would need to perform this several time for each
packet)

__skb_get_rxhash() is more tunnel aware, yet some protocols are still
missing, for example IPPROTO_IPV6.

Instead of adding logic to both dissectors, we could have a central flow
dissector, filling a temporary pivot structure with found elements (src
addr, dst addr, ports, ...), going through tunnels encap if found.

Then net/sched/cls_flow.c could pick needed elems from this structure to
compute the hash as specified in tc command :
(for example : tc filter ...  flow hash keys proto-dst,dst ...)

(One dissector call per packet for any number of keys in the filter)

Same for net/sched/sch_sfb.c : Use the pivot structure and compute the
two hashes (using two hashrnd values)

And __skb_get_rxhash() could use the same flow dissector, and pick (src
addr, dst addr, ports) to compute skb->rxhash, and set skb->l4_rxhash if
"ports" is not null.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html