netdev - Re: [bug?] r8169: hangs under heavy load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111127092808.GE21635@elie.hsd1.il.comcast.net>
Date:	Sun, 27 Nov 2011 03:28:08 -0600
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org,
	nic_swsd@...ltek.com, linux-kernel@...r.kernel.org,
	Armin Kazmi <armin.kazmi@...dortmund.de>,
	Gerd <booster@...ke7.net>
Subject: Re: [bug?] r8169: hangs under heavy load

Eric Dumazet wrote:
> Le samedi 26 novembre 2011 à 01:44 +0100, Francois Romieu a écrit :

>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index 6f06aa1..54be9e1 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -5820,8 +5820,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
>>  			case RTL_GIGA_MAC_VER_11:
>>  			case RTL_GIGA_MAC_VER_22:
>>  			case RTL_GIGA_MAC_VER_26:
>> -				netif_stop_queue(dev);
>> -				rtl8169_tx_timeout(dev);
>> +				rtl8169_schedule_work(dev, rtl8169_reset_task);
>>  				goto done;
>>  			/* Testers needed. */
>>  			case RTL_GIGA_MAC_VER_17:
>
> Please Jonathan, Gerd, try this fix !

Thanks, Eric.  Unfortunately I don't have the hardware.

Gerd, would you be able to try this patch?  It works like this:

  apt-get install git build-essential
  git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  cd linux
  ... apply the fix, for example using "patch -p1" ...
  make localmodconfig; # minimal configuration
  make deb-pkg
  dpkg -i ../<name of package>
  reboot

Feel free to email me privately if you have any questions.

Regards,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html