netdev - Re: [bug?] r8169: hangs under heavy load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED2A573.1020807@wolke7.net>
Date:	Sun, 27 Nov 2011 22:02:43 +0100
From:	booster@...ke7.net
To:	Jonathan Nieder <jrnieder@...il.com>
CC:	Eric Dumazet <eric.dumazet@...il.com>,
	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org,
	nic_swsd@...ltek.com, linux-kernel@...r.kernel.org,
	Armin Kazmi <armin.kazmi@...dortmund.de>
Subject: Re: [bug?] r8169: hangs under heavy load

Jonathan Nieder wrote:
> Eric Dumazet wrote:
>   
>> Le samedi 26 novembre 2011 à 01:44 +0100, Francois Romieu a écrit :
>>     
>
>   
>>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>>> index 6f06aa1..54be9e1 100644
>>> --- a/drivers/net/ethernet/realtek/r8169.c
>>> +++ b/drivers/net/ethernet/realtek/r8169.c
>>> @@ -5820,8 +5820,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
>>>  			case RTL_GIGA_MAC_VER_11:
>>>  			case RTL_GIGA_MAC_VER_22:
>>>  			case RTL_GIGA_MAC_VER_26:
>>> -				netif_stop_queue(dev);
>>> -				rtl8169_tx_timeout(dev);
>>> +				rtl8169_schedule_work(dev, rtl8169_reset_task);
>>>  				goto done;
>>>  			/* Testers needed. */
>>>  			case RTL_GIGA_MAC_VER_17:
>>>       
>> Please Jonathan, Gerd, try this fix !
>>     
>
> Thanks, Eric.  Unfortunately I don't have the hardware.
>
> Gerd, would you be able to try this patch?  It works like this:
>
>   apt-get install git build-essential
>   git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>   cd linux
>   ... apply the fix, for example using "patch -p1" ...
>   make localmodconfig; # minimal configuration
>   make deb-pkg
>   dpkg -i ../<name of package>
>   reboot
>
> Feel free to email me privately if you have any questions.
>
> Regards,
> Jonathan
>
>   
Jonathan, I compiled a new kernel with the patch described above but the
behavior
is still the same. During high network load the link hangs:

[  195.332478] r8169 0000:02:00.0: eth0: link up
[  222.517171] r8169 0000:02:00.0: eth0: link up
[  222.908277] r8169 0000:02:00.0: eth0: link up
[  223.508249] r8169 0000:02:00.0: eth0: link up

Is there a way to activate more driver debugging in the kernel ?

Best Regards,
Gerd


View attachment "dmesg_20111127_kernel_3.2_r8169-patch.txt" of type "text/plain" (49379 bytes)