netdev - Re: [PATCH net-next 2/8] dsa: Export functions from core to modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Nov 2011 22:38:57 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] dsa: Export functions from core to modules

On Sun, 2011-11-27 at 20:15 +0100, Lennert Buytenhek wrote:
[...]
> > diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> > index 56cf9b8..c9d52ca 100644
> > --- a/net/dsa/slave.c
> > +++ b/net/dsa/slave.c
> > @@ -45,6 +45,7 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds)
> >  			ds->master_mii_bus->id, ds->pd->sw_addr);
> >  	ds->slave_mii_bus->parent = &ds->master_mii_bus->dev;
> >  }
> > +EXPORT_SYMBOL_GPL(dsa_slave_mii_bus_init);
> >  
> > 
> >  /* slave device handling ****************************************************/
> > @@ -402,3 +403,4 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
> >  
> >  	return slave_dev;
> >  }
> > +EXPORT_SYMBOL_GPL(dsa_slave_create);
> 
> Why do these need to be exported?  They are only called from dsa.c,
> and dsa.c and slave.c are always linked into the same entity, even
> after your patches.

Oh, yes.  I just failed to revert these exports when I decided they
should be linked together.

Ben.

-- 
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)