netdev - Re: [PATCH net-next 6/8] dsa: Allow core and drivers to be built as modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1322433564.7454.33.camel@deadeye>
Date:	Sun, 27 Nov 2011 22:39:24 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 6/8] dsa: Allow core and drivers to be built as
 modules

On Sun, 2011-11-27 at 20:19 +0100, Lennert Buytenhek wrote:
> On Sat, Nov 26, 2011 at 12:38:38AM +0000, Ben Hutchings wrote:
> 
> > Change the kconfig types to tristate and adjust the condition for
> > declaring net_device::dsa_ptr to allow for this.
> > 
> > Adjust the makefile so that if NET_DSA_MV88E6123_61_65=y and
> > NET_DSA_MV88E6131=m or vice versa then both drivers are built-in.  We
> > could leave these options as bool and make NET_DSA_MV88E6XXX a
> > user-selected option, but that would break existing configurations.
> > 
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> Acked-by: Lennert Buytenhek <buytenh@...tstofly.org>
> 
> Thanks for the patches!
> 
> (While you're at it -- the switch chip drivers in net/dsa/ still
> ought to be moved to drivers/net/dsa/ or so -- feel like whipping up
> a patch for that?)

I agree.  Maybe.

Ben.

-- 
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)