netdev - Re[2]: [v4 PATCH 2/2] NETFILTER userspace part for target HMARK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1111281318310.20051@frira.zrqbmnf.qr>
Date:	Mon, 28 Nov 2011 13:23:53 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Hans Schillstrom <hans@...illstrom.com>
cc:	Hans Schillström <hans.schillstrom@...csson.com>,
	"kaber@...sh.net" <kaber@...sh.net>,
	"pablo@...filter.org" <pablo@...filter.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re[2]:  [v4 PATCH 2/2] NETFILTER userspace part for target  HMARK

On Monday 2011-11-28 09:37, Hans Schillstrom wrote:

>>>>>+Parameters:
>>>>>+For all masks default is all "1:s", to disable a field use mask 0
>>>>>+For IPv6 it's just the last 32 bits that is included in the hash
>>>>
>>>>Why limit IPv6 to 32?
>>>
>>>Performance, and the gain of adding another 192 bits to jhash ain't much.
>>>However there is some cases when it hurts, i.e. when you can't mask of an subnet
>>>I'm not sure it it's a problem or not... 
>>
>>I was thinking about the case where two particular hosts have the same 
>>trailing 32 bits in their source address. For example, assuming IPv6 
>>starts to take a stronghold in the real world and home customers start 
>>assigning <myprefix>::1 to the little home server (i.e. the PPP 
>>endpoint) of theirs for remote login.
>
>Yes that's a good point,  I will have a look at this and see haw to speed-up the IPv6 calc.
>
>btw
>parsing by using xoption.c  is there a way to allow both hex format and mask length ?
>i.e. --smask 0xffff0000   or  --smask /16

That has never been used before, so no, you will need to use 
XTTYPE_STRING and then parse it out.

Having /n besides n looks like feature creep (for values up to 2^32-1). 
xt_mark does not have a /n, just saying.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html