netdev - Re: [PATCH] net: net_device flags is an unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322714894.2577.19.camel@edumazet-laptop>
Date:	Thu, 01 Dec 2011 05:48:14 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: net_device flags is an unsigned int

Le mercredi 30 novembre 2011 à 23:39 -0500, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 01 Dec 2011 05:34:37 +0100
> 
> > -	unsigned short old_flags = dev->flags;
> > +	typeof(dev->flags) old_flags = dev->flags;
> 
> Please, create netdev_flags_t or similar, anything but this :-)

Hmm, I thought Linus hated types like this...

Or how explain we dont have jiffies_t or similar ? ;)

Other choice would be a generic macro...

int dev_set_promiscuity(struct net_device *dev, int inc)
{
DEFINE_VARIABLE(temp, dev->flags);
...
}

Hmm...


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html