netdev - Re: [PATCH] net: net_device flags is an unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111201.000528.1901790543147589391.davem@davemloft.net>
Date:	Thu, 01 Dec 2011 00:05:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: net_device flags is an unsigned int

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 01 Dec 2011 05:48:14 +0100

> Le mercredi 30 novembre 2011 à 23:39 -0500, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Thu, 01 Dec 2011 05:34:37 +0100
>> 
>> > -	unsigned short old_flags = dev->flags;
>> > +	typeof(dev->flags) old_flags = dev->flags;
>> 
>> Please, create netdev_flags_t or similar, anything but this :-)
> 
> Hmm, I thought Linus hated types like this...

Yes, it is true.  But look at netdev_features_t

> Or how explain we dont have jiffies_t or similar ? ;)

:-)

Like you I just want something that automatically tracks any future
changes to the type.  However I want something that doesn't look so
ugly like that typeof() thing.

Sure, use typeof() in macros, you can hide it in such places.

But please not in plain sight in *.c files.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html