netdev - Re: [PATCH net-next V0 03/21] mlx4_core: Add "native" argument to mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1RGDXh0-v075fdxvoA=sL0vOq1ncouNNH5v3y7QFHJmnnQEA@mail.gmail.com>
Date:	Fri, 2 Dec 2011 09:01:00 -0800
From:	Roland Dreier <roland@...estorage.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, liranl@...lanox.co.il,
	jackm@....mellanox.co.il
Subject: Re: [PATCH net-next V0 03/21] mlx4_core: Add "native" argument to
 mlx4_cmd and its callers (where needed)

On Fri, Dec 2, 2011 at 2:16 AM, Yevgeny Petrilin
<yevgenyp@...lanox.co.il> wrote:
>        return mlx4_cmd(dev, limit_watermark, srq_num, 0, MLX4_CMD_ARM_SRQ,
> -                       MLX4_CMD_TIME_CLASS_B);
> +                       MLX4_CMD_TIME_CLASS_B, 0);

Instead of a 0 or 1 for the native parameter, can we define something like

enum {
           MLX4_CMD_NATIVE,
           MLX4_CMD_WRAPPED
};

so that all these calls become easier to read?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html