netdev - RE: [PATCH net-next V0 03/21] mlx4_core: Add "native" argument to mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <953B660C027164448AE903364AC447D22362736D@MTLDAG01.mtl.com>
Date:	Sun, 4 Dec 2011 10:43:51 +0000
From:	Yevgeny Petrilin <yevgenyp@...lanox.com>
To:	Roland Dreier <roland@...estorage.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Liran Liss <liranl@...lanox.com>,
	"jackm@....mellanox.co.il" <jackm@....mellanox.co.il>
Subject: RE: [PATCH net-next V0 03/21] mlx4_core: Add "native" argument to
 mlx4_cmd and its callers (where needed)

> >        return mlx4_cmd(dev, limit_watermark, srq_num, 0, MLX4_CMD_ARM_SRQ,
> > -                       MLX4_CMD_TIME_CLASS_B);
> > +                       MLX4_CMD_TIME_CLASS_B, 0);
> 
> Instead of a 0 or 1 for the native parameter, can we define something like
> 
> enum {
>            MLX4_CMD_NATIVE,
>            MLX4_CMD_WRAPPED
> };
> 
> so that all these calls become easier to read?
 
Agree,
We will change this for next round.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html