netdev - Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 03 Dec 2011 23:28:36 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>,
	Flavio Leitner <fbl@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

On Sat, 2011-12-03 at 19:26 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Sat,  3 Dec 2011 03:44:26 -0800
> 
> > +	if ((!adapter->tx_hang_recheck) &&
> 
> Excessive parenthesis, please remove.
> 
> > +		adapter->tx_hang_recheck = 1;
> 
> This variable is a bool, set it to true or false.
> 
> > +			adapter->tx_hang_recheck = 0;
> 
> Likewise.
> 
> > +	adapter->tx_hang_recheck = 0;
> 
> Likewise.

Michael/Flavio -

To expedite this patch, I can make the changes that Dave is requesting
and re-submit v2 of the patch, if that is ok with you.

-Jeff

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)